Conversation
870a27f to
34e5574
Compare
34e5574 to
131a872
Compare
maudetes
left a comment
There was a problem hiding this comment.
Have you tried using the logic for granular resource permission described in Flask Principal?
I think we may add the partial organization needs in inject_organization_needs?
I think we can also decide to add permissions in |
I changed it in 07bbc62, it's simpler but not lazy. We fetch all assignations at the beginning of every requests. It could be also a problem if someone has a lot of assignations. But it's easy to change later if we have perfs problems. It also solves the problem with permissions in list since we have the information before-hand. |
Not sure if it's the right implementation, maybe the simplest?
I'm not sure how to send these permission to cdata. If we create a
permissionsobject on theDataset, we may need to do n queries to fetch the permission for all datasets in a list (for exemple in a pagination…). Is it a problem?Other possible implementations:
Flask-Principaland create a simpler permission systemMemberobject but it adds a lot of things inside theOrganisationobject?